Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] FASTQSCREEN_FASTQSCREEN should accept multiple inputs with a single database #6890

Open
ferenckata opened this issue Oct 29, 2024 · 2 comments

Comments

@ferenckata
Copy link

ferenckata commented Oct 29, 2024

Is your feature request related to a problem? Please describe

When you provide an input channel of fastq files to FASTQSCREEN_FASTQSCREEN, only the first one is run because there is only one database.

Describe the solution you'd like

I think you need to accept database as a value and allow it to not limit the execution, e.g. with each statement. In the tests it is always tested with a single input, so probably would be a good idea to update those too.

Describe alternatives you've considered

One could repeat the input database path as many times as many reads there are, but that is a workaround and a hacky solution.
Or the input can be tuple val(meta), path(read), path(database) so that with combine() it can be solved.

Additional context

No response

@edmundmiller
Copy link
Contributor

Hey! We hacked this out last week here nf-core/seqinspector#53

Would love your review on it!

@FranBonath
Copy link
Member

Hej @edmundmiller,
@kedhammar and myself found a problem with this solution. Mainly, Multiqc can't handle it when the fastqscreen results are split over several files. The first problem is that the different fastqscreen output files for the same sample are called the same and get overwritten in the results and in the Multiqc mix. But even when that is resolved, the Multiqc report still only contains one result per sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants