-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module: MAFFT/GUIDETREE #7096
Comments
Hey @MillironX @Joon-Klaps , I would like to add a mode of MAFFT to generate only a guide tree (https://mafft.cbrc.jp/alignment/software/treeout.html). To do this, I will have to move MAFFT to MAFFT/ALIGN. What do you think? |
This is currently my PR |
Is there a need to create a new module for this over just adding an optional output to the current module? |
I think technically it could be done in one module - although both outputs would need to be optional. When it does only tree rendering - it will not output the MSA. In other cases, FAMSA, CLUSTALO, we finally decided to split it into its different modes, to make it a bit more easy to use. I personally like it more split into submodules, but if you have strong feelings against it I could change it to have the optional outputs. |
Nope, no strong feelings here 😄. If other modules have done something similar, I'm all for consistency across tools so go for it! Ping me when you need a review. |
Hey @Joon-Klaps, great! :) The PR is ready, I got a review already but because they had to check the code because there were some errors with the linter. |
Is there an existing module for this?
Is there an open PR for this?
Is there an open issue for this?
Further Information
No response
Are you going to work on this?
Assignees
to facilitate tracking who is working on the moduleThe text was updated successfully, but these errors were encountered: