Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: MAFFT/GUIDETREE #7096

Closed
3 of 4 tasks
luisas opened this issue Nov 26, 2024 · 6 comments · Fixed by #7097
Closed
3 of 4 tasks

new module: MAFFT/GUIDETREE #7096

luisas opened this issue Nov 26, 2024 · 6 comments · Fixed by #7097
Assignees
Labels
new module Adding a new module

Comments

@luisas
Copy link
Contributor

luisas commented Nov 26, 2024

Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Further Information

No response

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module
@luisas luisas added the new module Adding a new module label Nov 26, 2024
@luisas luisas self-assigned this Nov 26, 2024
@luisas luisas mentioned this issue Nov 26, 2024
17 tasks
@luisas
Copy link
Contributor Author

luisas commented Nov 27, 2024

Hey @MillironX @Joon-Klaps , I would like to add a mode of MAFFT to generate only a guide tree (https://mafft.cbrc.jp/alignment/software/treeout.html).

To do this, I will have to move MAFFT to MAFFT/ALIGN. What do you think?

@luisas
Copy link
Contributor Author

luisas commented Nov 27, 2024

This is currently my PR
#7097

@Joon-Klaps
Copy link
Contributor

Is there a need to create a new module for this over just adding an optional output to the current module?

@luisas
Copy link
Contributor Author

luisas commented Nov 27, 2024

I think technically it could be done in one module - although both outputs would need to be optional. When it does only tree rendering - it will not output the MSA.

In other cases, FAMSA, CLUSTALO, we finally decided to split it into its different modes, to make it a bit more easy to use.

I personally like it more split into submodules, but if you have strong feelings against it I could change it to have the optional outputs.

@Joon-Klaps
Copy link
Contributor

Nope, no strong feelings here 😄. If other modules have done something similar, I'm all for consistency across tools so go for it! Ping me when you need a review.

@luisas
Copy link
Contributor Author

luisas commented Nov 27, 2024

Hey @Joon-Klaps, great! :)

The PR is ready, I got a review already but because they had to check the code because there were some errors with the linter.
So I do not need the review, thanks a ton anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants