Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port parabricks/mutectcaller to nf-test #6991

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Nov 14, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab requested a review from a team as a code owner November 14, 2024 10:39
@famosab
Copy link
Contributor Author

famosab commented Nov 14, 2024

PON test does not work because:
// // PON test not passing because the tool expects all chromosomes in the PON file to
// // be present in the reference genome.

Tumor-Normal tests do not work because:
// // tumor-normal calling not passing because of issue with readgroups in the test files
// // [PB Error][src/readers.cpp:1314] ID simulation01 maps to tm_simulation01, but PU is nm_simulation01 (different platform), exiting.

@famosab famosab added gpu module uses GPU nf-test help wanted Extra attention is needed labels Nov 18, 2024
@famosab famosab removed the help wanted Extra attention is needed label Dec 9, 2024
@famosab
Copy link
Contributor Author

famosab commented Dec 9, 2024

Intervals test fails with

│     /usr/local/parabricks/binaries/bin/mutect genome.fasta test2.paired_end.recalibrated.sorted.bam 1 -o test.vcf.gz -tumorsample tumor -nt 5 -L multi_intervals.bed -max-mnp-distance 1 --low-memory                                                                                                                       │
│     Exit with error: 1                                                                                                                                                                                                                                                                                                      │
│     For technical support visit https://docs.nvidia.com/clara/index.html#parabricks                                                                                                                                                                                                                                         │
│     Exiting...                                                                                                                                                                                                                                                                                                              │
│     Please visit https://docs.nvidia.com/clara/#parabricks for detailed documentation    

@famosab famosab added the help wanted Extra attention is needed label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu module uses GPU help wanted Extra attention is needed nf-test Ready for Review
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant