Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre filter and shard counting step #7025

Closed
wants to merge 18 commits into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 19, 2024

No description provided.

@mashehu mashehu requested a review from a team as a code owner November 19, 2024 15:10
@mashehu mashehu enabled auto-merge November 20, 2024 00:33
@mashehu mashehu requested a review from edmundmiller November 20, 2024 01:01
@sateeshperi
Copy link
Contributor

in gpu-tests.yml, the trigger is on PR to master and those paths. should we include subworkflows too that have gpu tests ?

  pull_request:
    branches: [master]
    paths:
      - ".github/workflows/gpu-tests.yml"
      - "modules/nf-core/parabricks/**"

@mashehu
Copy link
Contributor Author

mashehu commented Nov 20, 2024

I wouldn't at special paths just all modules and subworkflows. Then the filter step will take care of only picking up GPU tests

@sateeshperi
Copy link
Contributor

why aren't some tests not launching ?

@mashehu
Copy link
Contributor Author

mashehu commented Nov 20, 2024

they are not stalled, they are just required, but never launched (because we don't have anything to test). so we need to remove them from the ruleset and add a step which confirms the passing of all tests (either that they ran successfully or that they didn't have to be run)

@sateeshperi
Copy link
Contributor

closing this as we got some of the logic in and will polish in another PR with working fixes from methylseq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants