Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct non-gzipped output from clustalo/align #7197

Merged

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Dec 11, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

In profile mode, Clustal Omega sometimes writes warning messages to standard out which ruins the output file as it's not recognizable fasta any more. I fixed this by writing the output with -o instead of >.

I didn't add any test as it requires quite a bit of new test data. I did test the updated module on my own test case however.

@erikrikarddaniel erikrikarddaniel requested review from lrauschning and luisas and removed request for lrauschning December 11, 2024 14:24
@erikrikarddaniel erikrikarddaniel added this pull request to the merge queue Dec 11, 2024
Merged via the queue into nf-core:master with commit 7b32b09 Dec 11, 2024
27 checks passed
@erikrikarddaniel erikrikarddaniel deleted the fix-broken-clustalo-fasta branch December 11, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants