PR for first release #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important! Template update for nf-core/tools v2.9
First minimal working version of pipeline
Important! Template update for nf-core/tools v2.10
Create training subset functional
Molkartqc hotfix
This reverts commit 181c2ac. assets/nf-core-molkart_logo_light.png, docs/images/nf-core-molkart_logo_light.png, docs/images/nf-core-molkart_logo_dark.png should not be changed.
Changed mindagap params for full test to reduce runtime.
Module update + CI + final TODOs
updated mesmer to exlude leftover todo
|
apeltzer
approved these changes
Jan 24, 2024
adamrtalbot
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
The mixture of semantic versioning plus date is a bit confusing, I think you could use one or the other.
There was a problem hiding this comment.
Thanks for the tip! We were unsure how semantic versioning should change in the initial development phase which is why we added the dates to keep track.
There was a problem hiding this comment.
I quite like the dates. But I think having both in the title is confusing. How about:
v0.1.1
2024-01-30
- did a thing
2024-01-29
- did an earlier thing
but make it look nicer.
There was a problem hiding this comment.
I like it and will follow this for future updates :)
|
Thanks for the reviews @apeltzer and @adamrtalbot ! 😄 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR from
devtomasterfor Molkart.PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).