Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added full test config file. #39

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Added full test config file. #39

merged 4 commits into from
Dec 16, 2023

Conversation

FloWuenne
Copy link
Collaborator

PR checklist

This PR adds the config file for the full test dataset.

  • This comment contains a description of changes (with reason).
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3b654a3

+| ✅ 158 tests passed       |+
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in main.nf.test: Once you have added the required tests, please run the following command to build this file:
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-16 10:29:01

kbestak
kbestak requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kbestak kbestak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it after the param specifications are adjusted

conf/test_full.config Outdated Show resolved Hide resolved
@kbestak kbestak merged commit 9776860 into dev Dec 16, 2023
6 checks passed
@kbestak kbestak deleted the full_test branch December 16, 2023 10:36
@kbestak kbestak mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbestak kbestak kbestak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloWuenne @kbestak