Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiqc report fix #75

Closed
wants to merge 1 commit into from
Closed

Multiqc report fix #75

wants to merge 1 commit into from

Conversation

kbestak
Copy link
Collaborator

@kbestak kbestak commented Sep 9, 2024

Addresses #72
Added parameters necessary for create_training_subset to run with test.config for easier use.
Updated MultiQC version to 1.24.1
For easier testing in Gitpod, moved the Seqera Container for MultiQC to test.config instead of modules.config (as the Biocontainer cannot be pulled in Gitpod).
put .nf-test.log to .gitignore

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kbestak kbestak requested a review from FloWuenne September 9, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @kbestak,

It looks like this pull-request is has been made against the kbestak/nf_molkart master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the kbestak/nf_molkart dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@kbestak kbestak changed the base branch from master to dev September 9, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7d35334

+| ✅ 211 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-09 14:48:21

@kbestak kbestak closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloWuenne FloWuenne Awaiting requested review from FloWuenne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kbestak