Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge!] Pseudo PR for first release #9

Closed
wants to merge 195 commits into from
Closed

[Do not merge!] Pseudo PR for first release #9

wants to merge 195 commits into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jul 19, 2024

Do not merge! This is a PR of dev compared to the TEMPLATE branch for whole-pipeline reviewing purposes. Changes should be made to dev and this PR should not be merged into first-commit-for-pseudo-pr!

charles-plessy and others added 30 commits April 11, 2024 15:38
Added a 'target' parameter
Keeping it causes the pipeline to crash because of our changes
in assets/schema_input.json.
These includes seed, skip_dotplot___, targerName
Added 1st batch of new parameters
to overide the default target parameter, which is null and now target
Im waiting for your input concerning whether or not to use the 'if' here or nort to accomodate m2m, o2m, ...
Im waiting for your input concerning whether or not to use the 'if' here or nort to accomodate m2m, o2m, ...
...
@mashehu
Copy link
Contributor Author

mashehu commented Jul 24, 2024

Thanks for all your comments @mashehu ! May I ask for your help on one point? In the MultiQC output, we generate tables from tsv files that have column names like last -a. I would like to add a hover description for them, but could not find the correct syntax…

Let's discuss this over on slack. But you can maybe see how that is done using the following example https://github.com/MultiQC/test-data/blob/main/data/custom_content/embedded_config/table_headers_mqc.txt

@charles-plessy
Copy link
Collaborator

Hi @mashehu I think that we addressed all of your comments. The MultiQC report would benefit from more polishing but maybe that can be deferred to a later release? One final thing that I could not fix is that on the https://nf-co.re/pairgenomealign/dev/ page the pipeline's workflow image does not display, despite that it does fine on GitHub…

Copy link
Contributor Author

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the missing logo in the assets folder will not break the email/multiqc report, but rest looks good now. (can't approve this PR, because I opened it. will do on #8

### FastQC
Each _query_ genome, is aligned to the _target_ genome, and each alignment is visualised with dot plots. The output file names are constructed by concatenating the _target_ and _query_ sample identifiers with a `___` separator (three underscores), to faciliate re-extraction of the IDs from file names.

### Assembly statistics
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Assembly statistics
## Assembly statistics

If you decrease the heading level of this and the following headings to h2, the will show up in the ToC on the side. 🙂

@@ -72,7 +72,11 @@ For more details about the output files and reports, please refer to the

We thank the following people for their extensive assistance in the development of this pipeline:

- [Mahdi Mohammed](https://github.com/U13bs1125): ported the original pipeline to _nf-core_ template 2.14.x.
- [Mahdi Mohammed](https://github.com/U13bs1125) ported the original pipeline to _nf-core_ template 2.14.x.
- [Martin Frith](https://github.com/mcfrith/), the author of LAST, gave us extensive feedback and advices.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Martin Frith](https://github.com/mcfrith/), the author of LAST, gave us extensive feedback and advices.
- [Martin Frith](https://github.com/mcfrith/), the author of LAST, gave us extensive feedback and advice.

Comment on lines +23 to +25
id:
title: "ID"
description: "target___query"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is not working, but not such a big thing maybe...

@charles-plessy
Copy link
Collaborator

Closing as 1.0.0 is out 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants