Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v2.12 #120

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.12 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.12 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.12 release page.

Copy link

github-actions bot commented Feb 1, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ca46c28

+| ✅ 188 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnavar.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-01 16:39:05

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog update but otherwise LGTM

@@ -97,7 +97,7 @@
},
"read_length": {
"type": "number",
"default": 151,
"default": 150,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG update?

@maxulysse maxulysse merged commit ebb949b into dev Feb 2, 2024
12 checks passed
@maxulysse
Copy link
Member

Missing changelog update but otherwise LGTM

I'll take care of that in separate PR, I have other missing entries

@maxulysse maxulysse deleted the nf-core-template-merge-2.12 branch February 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants