Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert reference channels from queue to value channel #154

Merged
merged 1 commit into from
Nov 19, 2024
Merged

convert reference channels from queue to value channel #154

merged 1 commit into from
Nov 19, 2024

Conversation

fmalmeida
Copy link

PR checklist

  • Fixes dev branch works only on the first sample #145 converting reference channels from queue to value channel.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@fmalmeida fmalmeida requested a review from maxulysse November 15, 2024 08:30
@fmalmeida fmalmeida mentioned this pull request Nov 15, 2024
Closed
@fmalmeida
Copy link
Author

fmalmeida commented Nov 15, 2024 •
edited
Loading

This PR relates to error here where references are queue channels, and thus pipeline thus not run for all input samples.

before
sc_with_single_sample

after
sc_with_all_samples

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9915cc7

+| ✅ 225 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-15 08:33:11

@maxulysse maxulysse merged commit 25103d3 into dev Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmalmeida @maxulysse