Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data model analysis #470

Open
anngvu opened this issue Jun 20, 2024 · 0 comments
Open

Add data model analysis #470

anngvu opened this issue Jun 20, 2024 · 0 comments
Assignees

Comments

@anngvu
Copy link
Collaborator

anngvu commented Jun 20, 2024

Add analysis of data model changes in each PR that:

  1. Identifies the number of/which manifest templates affected by this change.
  2. Summarizes when keys may collide across files when schematic converts everything to uppercase (i.e. in the final output there is no distinguishing keys that were originally meningioma vs Meningioma in the source), which can lead to bugs. Also, when editing YAML in most code editors, using a duplicate key under the same parent is clearly pointed out, but duplicate keys can still happen across files. See ID collision for two entities MPNST and menigioma #450.
  3. Summarizes changes in numbers of props, classes, and enums.

The first is relevant for #312.

@anngvu anngvu self-assigned this Jun 20, 2024
@anngvu anngvu moved this to Todo in NF-OSI Sprints Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant