Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] minor: arc sync default commit message #97

Closed
Brilator opened this issue Jan 28, 2022 · 4 comments · Fixed by #220
Closed

[BUG] minor: arc sync default commit message #97

Brilator opened this issue Jan 28, 2022 · 4 comments · Fixed by #220
Assignees
@HLWeil

Comments

@Brilator
Copy link
Member

Is your feature request related to a problem? Please describe.
The default commit message during arc sync is "Update", which is very different from what arc update does.

Describe the solution you'd like
Maybe exchange for a somewhat more informative commit message like "sync changes via arcCommander".
@omaus
Copy link
Collaborator

omaus commented Jan 28, 2022

The idea behind this was that it says that the ARC was updated. But you are correct, it can be mistaken.
Your idea sounds quite good.

HLWeil added a commit that referenced this issue May 12, 2023
@HLWeil
update default commit message
cfb22f8 
#97
@HLWeil
Copy link
Member

HLWeil commented May 12, 2023

Changed to "sync changes via ARC Commander".

@HLWeil HLWeil closed this as completed May 12, 2023
@Brilator
Copy link
Member Author

maybe default add a date Wed Jun 14 13:58:43 CEST 2023 as well?
Could make finding commits easier.
#196

@Brilator Brilator reopened this Jun 14, 2023
@HLWeil
Copy link
Member

HLWeil commented Jul 20, 2023

Well, the commits all do have a date anyways, so I don't really see much gain from this.

HLWeil added a commit that referenced this issue Oct 11, 2023
@HLWeil
fix arc sync spamming gitignored files
06f606b 
#209
#97
@HLWeil HLWeil self-assigned this Oct 11, 2023
@HLWeil HLWeil mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HLWeil HLWeil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests and fixes nfdi4plants/ARCCommander
3 participants
@Brilator @HLWeil @omaus