Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] is it really necessary to nest static ontology terms #41

Open
kMutagene opened this issue Oct 26, 2023 · 2 comments
Open

Comments

@kMutagene
Copy link
Member

kMutagene commented Oct 26, 2023

currently, creating an arc-validate test with the nested static ontology structure looks like this:

ARCExpect.test (TestID.Name INVMSO.``Investigation Metadata``.INVESTIGATION.``Investigation Title``.Name) {
    cvParams
    |> ARCExpect.ByTerm.contains INVMSO.``Investigation Metadata``.INVESTIGATION.``Investigation Title``
}

this is a LOT of noise. INVMSO has < 100 terms. i think it would be both easier AND more discoverable to create a flat class, so that it would just be

ARCExpect.test (TestID.TermName INVMSO.``Investigation Title``) {
    cvParams
    |> ARCExpect.ByTerm.contains INVMSO.``Investigation Title``
}

This way. you would have all possible terms once you write INVMSO. without the need of knowing about any nested structure.

@muehlhaus
Copy link
Member

I like the approach in order to reduce noise. Just keep in mind, that for the 'error' message we need the complete information... maybe we use custom attributes to get the full path

@omaus
Copy link
Collaborator

omaus commented Oct 26, 2023

@kMutagene Looks really good to me! Yet I would like to know if the complete information (i.e., the parent terms) is still accessible when working that way (as @muehlhaus pointed out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants