Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms with long and short annotation should be handled as equal #61

Open
HLWeil opened this issue Nov 15, 2024 · 4 comments
Open

Terms with long and short annotation should be handled as equal #61

HLWeil opened this issue Nov 15, 2024 · 4 comments
Assignees

Comments

@HLWeil
Copy link
Member

HLWeil commented Nov 15, 2024

let short = CvTerm.create("DPBO:1000164","plant growth protocol","DPBO")
let long = CvTerm.create("http://purl.org/nfdi4plants/ontology/dpbo/DPBO_1000164","plant growth protocol","DPBO")

short = long

returns false, but should IMO return true.

@omaus
Copy link
Collaborator

omaus commented Nov 17, 2024

Don't understand... you want to have the URI directly transformed into the respective ID (on creation) or that .Compare() does that only on comparison? @HLWeil

@omaus omaus self-assigned this Nov 17, 2024
@omaus omaus moved this to Ready in ARCStack Nov 20, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Nov 20, 2024

In the example above, I create two ontology term objects that are equal, as they both depict the same ontology term "DPBO:1000164", just in different formats.

But logic is missing which covers this. Therefore there can be validation cases which only work against one of the two formats.

@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Nov 20, 2024
@omaus
Copy link
Collaborator

omaus commented Nov 20, 2024

I should use the same logic as in ARCtrl. @omaus

@HLWeil
Copy link
Member Author

HLWeil commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants