Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upload from network folder #181

Closed
frsommer opened this issue May 14, 2024 · 8 comments
Closed

Enable upload from network folder #181

frsommer opened this issue May 14, 2024 · 8 comments
Assignees
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@frsommer
Copy link

Is your feature request related to a problem? Please describe.
ARC stored and edited on an network drive. When trying to commit / upload error occurs:

git checkout tal: detected dubious ownership in repository at '//syno.bio.uni-kl.de/biotech/ARCsyncETC/test/testarc/testarc'
fatal: detected dubious ownership in repository at '//syno.bio.uni-kl.de/biotech/ARCsyncETC/test/testarc/testarc'
'//syno.bio.uni-kl.de/biotech/ARCsyncETC/test/testarc/testarc' is owned by:
'S-1-5-21-1036228674-4065426080-1347446729-74989'
but the current user is:
'S-1-5-21-1788749962-3905053420-4232863692-500'
To add an exception for this directory, call:
git config --global --add safe.directory '%(prefix)///syno.bio.uni-kl.de/biotech/ARCsyncETC/test/testarc/testarc'

Describe the solution you'd like
be able to commit and push data from networkdrive, give it the option to be a save directory (last line in error message)

Describe alternatives you've considered
same happened as well with ARCcommander, after starting sync error occured, then i executed the git command (the folder added to save directory) and everything worked fine

Additional context
Add any other context or screenshots about the feature request here.

@Freymaurer Freymaurer added the Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature label Jun 5, 2024
@Freymaurer Freymaurer moved this to Backlog in ARCStack Jun 5, 2024
@Brilator
Copy link
Member

Related to this

#114

@Brilator
Copy link
Member

Could theoretically be fixed with adding safe directory to gitconfig

@JonasLukasczyk
Copy link
Collaborator

This is something that needs to be handled outside ARCitect. A git repository on a network drive introduces ambiguities regarding credentials.

@github-project-automation github-project-automation bot moved this from Backlog to Done in ARCStack Jul 22, 2024
@Brilator
Copy link
Member

A git repository on a network drive introduces ambiguities regarding credentials.

True, but how to properly handle that outside of ARCitect?
The design decision was made to ship the git binary; so users without git installed won't be able to adapt that config.

@Brilator Brilator reopened this Jul 22, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 22, 2024
@JonasLukasczyk JonasLukasczyk closed this as completed by moving to Done in ARCStack Sep 3, 2024
@JonasLukasczyk
Copy link
Collaborator

I will close this for now because multiple people editing the same repo in a shared file system goes a bit against the intended use of git (in which every user has a local copy). If this is still relevant feel free to reopen the issue and we will find a fix.

@JonasLukasczyk JonasLukasczyk removed the Status: Needs Triage This item is up for investigation. label Sep 3, 2024
@Brilator Brilator reopened this Sep 9, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 9, 2024
@Brilator
Copy link
Member

Brilator commented Sep 9, 2024

Agree that multiple people should collaborate via git / gitlab logic (not on same location on a server).
But that's not the issue here. Users don't want to share there large files (ARCs) on personal computers, but rather store them directly on a shared NAS (also for additional backups, etc.).

@JonasLukasczyk JonasLukasczyk removed the Status: Needs Triage This item is up for investigation. label Sep 25, 2024
@Tom-TBT
Copy link

Tom-TBT commented Nov 7, 2024

Same issue here. We have about 100 images of 50 GB each currently on a fileserver, that we must upload to the cloud. Copying the images locally first is not an option.

In the meantime, I can try the git config --global --add safe.directory workaround.

@JonasLukasczyk
Copy link
Collaborator

This flag is now set by default 93c5cef. Please note that using git on a shared storage can leak git credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: Done
Development

No branches or pull requests

5 participants