Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] xlsx merge #272

Closed
Brilator opened this issue Sep 26, 2024 · 1 comment
Closed

[BUG] xlsx merge #272

Brilator opened this issue Sep 26, 2024 · 1 comment
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Brilator
Copy link
Member

Tested the new xlsx merge feature.
This works fine when changes were committed to different files
I would just suggest to add a note (e.g. "please pull from the remote first") or offer a pull-button in the dialog when the error occurs.

error: failed to push some refs to 'https://git.nfdi4plants.org/brilator/ArcPrototype.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
...

Also, after pulling+merging, I ran into a fatal error, although the merge seemed to have worked.

Successfully rebased and updated refs/heads/main.
git -c core.editor=true rebase --continue
fatal: No rebase in progress?
git status
On branch main
nothing to commit, working tree clean

Merging changes done on the same file worked, but the dialog did not show what was changed.

Screenshot 2024-09-26 at 09 06 25

ARCitect v0.0.44
macOS

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 26, 2024
@JonasLukasczyk JonasLukasczyk added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Sep 26, 2024
@JonasLukasczyk JonasLukasczyk self-assigned this Sep 26, 2024
@JonasLukasczyk
Copy link
Collaborator

Fixed (029fa29)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

2 participants