Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Non-assay folder should not trigger Swate #306

Open
Brilator opened this issue Nov 27, 2024 · 3 comments
Open

[BUG] Non-assay folder should not trigger Swate #306

Brilator opened this issue Nov 27, 2024 · 3 comments
Assignees
@JonasLukasczyk
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@Brilator
Copy link
Member

If users add folders to "assays" that are simply additional payload and not really an ARC assay, ARCitect still triggers the swate view and runs into this error:

Screenshot 2024-11-27 at 11 04 46

This then looks like an ARCitect / Swate site error (while it's merely a user not following the ARC idea).
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 27, 2024
@Brilator
Copy link
Member Author

Same for studies of course

@JonasLukasczyk JonasLukasczyk self-assigned this Dec 2, 2024
@JonasLukasczyk
Copy link
Collaborator

We can add an additional check to see if a folder is actually a study/assay. Although adding folders inside the assays directory which are not assays seems incorrect.

@JonasLukasczyk JonasLukasczyk added Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Dec 2, 2024
@Brilator
Copy link
Member Author

Brilator commented Dec 2, 2024

"additional payload"

ARCs can include additional payload ... these files can be placed anywhere in the ARC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasLukasczyk JonasLukasczyk

Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
ARCStack
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Brilator @JonasLukasczyk