Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] whitespace in study / assay names / identifiers #418

Closed
Brilator opened this issue Jul 15, 2024 · 2 comments
Closed

[BUG] whitespace in study / assay names / identifiers #418

Brilator opened this issue Jul 15, 2024 · 2 comments
Assignees
@JonasLukasczyk
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Brilator
Copy link
Member

ARCitect hangs when adding a new study / assay with whitespace.

  • OS: macOS
  • ARCitect v.0.0.38
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 15, 2024
@JonasLukasczyk JonasLukasczyk self-assigned this Jul 15, 2024
@JonasLukasczyk JonasLukasczyk added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Jul 15, 2024
@JonasLukasczyk
Copy link

JonasLukasczyk commented Jul 15, 2024 •
edited
Loading

Turns out ARCtrl declares identifiers valid if they contain spaces at the beginning or end of an identifier (see checkValidCharacters), but then later encounters errors when processing objects with such identifiers. Since f73fdd6c0b83a5976ac6026a203dae26bdc139e9 the ARCitect UI logic now prevents the creation of such invalid identifiers, but this additional check should be added to the ARCtrl logic as well. I will close this for now. @Freymaurer

@Freymaurer
Copy link
Collaborator

I will reopen and transfer to ARCtrl

@Freymaurer Freymaurer reopened this Jul 16, 2024
@Freymaurer Freymaurer transferred this issue from nfdi4plants/ARCitect Jul 16, 2024
@Freymaurer Freymaurer closed this as completed by moving to Done in ARCStack Jul 16, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 16, 2024
@Freymaurer Freymaurer reopened this Jul 18, 2024
@Freymaurer Freymaurer removed the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@HLWeil HLWeil closed this as completed by moving to Done in ARCStack Jul 30, 2024
@HLWeil HLWeil removed the status in ARCStack Jul 30, 2024
@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasLukasczyk JonasLukasczyk

Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
ARCStack
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Brilator @HLWeil @JonasLukasczyk @Freymaurer