Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend DataPLANT 2FA #19

Open
Brilator opened this issue May 7, 2024 · 5 comments
Open

Recommend DataPLANT 2FA #19

Brilator opened this issue May 7, 2024 · 5 comments
Assignees

Comments

@Brilator
Copy link
Member

Brilator commented May 7, 2024

KeyCloak comes with 2FA and if I'm not mistaken there's a reason why this is recommended over the 2FA offered inside the hub.

I would suggest to disable the 2FA inside DataHUB or link / recommend to keycloak from there with an explanation.

Screenshot 2024-05-07 at 13 11 34
@j-bauer
Copy link
Collaborator

j-bauer commented May 7, 2024

That's definitely the way to go. We need to check how to disable the 2FA functionality in the DataHUB and point to the Keycloak-based 2FA setup page. @TetraW could you have a look at how to do that?

@TetraW
Copy link
Collaborator

TetraW commented May 7, 2024

That's definitely the way to go. We need to check how to disable the 2FA functionality in the DataHUB and point to the Keycloak-based 2FA setup page. @TetraW could you have a look at how to do that?

Yes, I will look into it!

EDIT: It looks like it is possible to deactivate 2FA globally for all users, using GitLab Rake tasks (https://docs.gitlab.com/16.11/ee/security/two_factor_authentication.html#for-all-users), I will look into it further in the next days together with an update to the current GitLab version (16.11.1).

@TetraW TetraW self-assigned this May 7, 2024
@Brilator
Copy link
Member Author

Brilator commented May 7, 2024

Perfect, thanks.
Then maybe just add a banner or auto-email to those users who currently use 2FA via GitLab.

@TetraW
Copy link
Collaborator

TetraW commented May 17, 2024

@Brilator @j-bauer
Unfortunately, things were a little more complicated than initially assumed. Using the GitLab Rake tasks, 2FA authentication can only be deactivated for users who have already activated it. This is more intended to enable access again if the second factor is lost. But it was not possible to deactivate the option to use 2FA authentication in this way.

However, I was able to “hide” the option with the help of a patch. This has so far only been implemented in the DataHUB on premise version. Here is a screenshot of the “Account” page after the patch.

Screenshot_DataHUB_2FA

@eik-dahms
Copy link

image

Maybe a non deletious solution would be better for non Datahub authentification? You can see an example in action here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants