Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Rename table to template name on import #489

Closed
Tracked by #499
shiltemann opened this issue Jul 18, 2024 · 4 comments
Closed
Tracked by #499

[Feature Request] Rename table to template name on import #489

shiltemann opened this issue Jul 18, 2024 · 4 comments
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@shiltemann
Copy link

Is your feature request related to a problem? Please describe.
I often load a template, then manually rename the table from the default title "NewTableX" to the name of the template.

Describe the solution you'd like
It would be convenient if it automatically renamed the table to the template name when loading a table from template.

Describe alternatives you've considered
Manually renaming is not a big deal, but I just find myself using the template name as table title most of the time, so it feels like it could be automated and save people some time.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@Freymaurer Freymaurer added Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Jul 18, 2024
@Freymaurer
Copy link
Collaborator

Doing things the user does not specifically intend to do is always hit-or-miss. Imagine you added a template and did not want to rename your table. Then you wold be very annoyed because you wanted to add a template and not rename the table.

In the reverse case of you wanting to rename the table, you also do not get what you want but you get what you would expect.

We could in the future offer an additional button/checkbox to rename the table.

@Freymaurer Freymaurer transferred this issue from nfdi4plants/ARCitect Jul 18, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@shiltemann
Copy link
Author

Fair enough, perhaps only if the table name is still at the default? Offering a checkbox makes it the most explicit in terms of expectations, agreed.

Or perhaps instead of having it be a 2 step process of adding a new table followed by loading a template, make it a single action, "add table from template"?

@Freymaurer Freymaurer removed the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@Freymaurer
Copy link
Collaborator

Yeah the template add logic will soon receive a rework, partially based on how protocol import from files looks like:

image

@Freymaurer
Copy link
Collaborator

Tracked in #499 will close here

@github-project-automation github-project-automation bot moved this from Backlog to Done in ARCStack Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: Done
Development

No branches or pull requests

2 participants