-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature excel enable multiple templates #592
Open
Etschbeijer
wants to merge
23
commits into
main
Choose a base branch
from
Feature_Excel_EnableMultipleTemplates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b74953d
Create basic structure for adding multiple templates
Etschbeijer 488a75b
Enable viewing of all selected templates
Etschbeijer dc3e485
Add minor refactoring
Etschbeijer 41c76e6
Removed templateSelected
Etschbeijer 1486fc6
Implement selectImportType
Etschbeijer 57251b3
Enable import of multiple templates with add and join
Etschbeijer 0fee87f
Enable adding and joining of templates
Etschbeijer 8de6cb0
Enable merging of different cell types from template
Etschbeijer d726241
Implement import of multiple templates in swate alpha
Etschbeijer d43aae3
implement review changes
Etschbeijer a8e7eae
Simplify code
Etschbeijer ec72dc3
Implement regex fix
Etschbeijer 500dc72
Reduce code duplication :fire:
Freymaurer c5739f1
Move selected box above template search
Etschbeijer 7d14e3a
removed line
Etschbeijer 5b22abf
Replace worksheet name with template name instead of table name
Etschbeijer f6aa09a
Add summaries
Etschbeijer f568dcd
implemented review changes
Etschbeijer 4f0359c
Implement review changes
Etschbeijer 31a0d13
Undo changes to pagestate
Etschbeijer 286e7dc
Implement review changes
Etschbeijer 02780e2
implement review requests
Etschbeijer 2046195
Implement review changes
Etschbeijer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,27 +14,27 @@ type SidebarView = | |
Html.div [ | ||
prop.className "grow overflow-y-auto" | ||
prop.children [ | ||
match model.ProtocolState with | ||
| {WidgetTypes = Routing.WidgetTypes.BuildingBlock } -> | ||
BuildingBlock.Core.addBuildingBlockComponent model dispatch | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.TermSearch } -> | ||
TermSearch.Main (model, dispatch) | ||
if model.ProtocolState.IsProtocolSearch then | ||
Protocol.SearchContainer.Main model dispatch | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this if-else logic into the protocol view logic, do not handle this in sidebarview anymore There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
else | ||
match model.PageState with | ||
| {SidebarPage = Routing.SidebarPage.BuildingBlock } -> | ||
BuildingBlock.Core.addBuildingBlockComponent model dispatch | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.FilePicker } -> | ||
FilePicker.filePickerComponent model dispatch | ||
| {SidebarPage = Routing.SidebarPage.TermSearch } -> | ||
TermSearch.Main (model, dispatch) | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.Protocol } -> | ||
Protocol.Templates.Main (model, dispatch) | ||
| {SidebarPage = Routing.SidebarPage.FilePicker } -> | ||
FilePicker.filePickerComponent model dispatch | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.DataAnnotator } -> | ||
Pages.DataAnnotator.Main(model, dispatch) | ||
| {SidebarPage = Routing.SidebarPage.Protocol } -> | ||
Protocol.Templates.Main (model, dispatch) | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.JsonExport } -> | ||
JsonExporter.Core.FileExporter.Main(model, dispatch) | ||
| {SidebarPage = Routing.SidebarPage.DataAnnotator } -> | ||
Pages.DataAnnotator.Main(model, dispatch) | ||
|
||
| {WidgetTypes = Routing.WidgetTypes.ProtocolSearch } -> | ||
Protocol.SearchContainer.Main model dispatch | ||
| {SidebarPage = Routing.SidebarPage.JsonExport } -> | ||
JsonExporter.Core.FileExporter.Main(model, dispatch) | ||
] | ||
] | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not required, correct? As you would already be on the search screen? Remove it if it is not necessary to allow reusing this Msg in different logic approaches without switching to search view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed