Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No DefinedTerm Profile Defined #24

Closed
floWetzels opened this issue Sep 3, 2024 · 2 comments
Closed

No DefinedTerm Profile Defined #24

floWetzels opened this issue Sep 3, 2024 · 2 comments
Labels
Status: Needs Triage This item is up for investigation.

Comments

@floWetzels
Copy link
Collaborator

Our ISA-RO-Crate profile doesn't contain any specification/profile regarding the type DefinedTerm, although it is an essential part at the core of the ISA model and many properties require it in their type range. Is this an oversight or was it intentional? After all, we do not require any specific restrictions, but it seems weird to me nonetheless.

@HLWeil @stuzart
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Sep 3, 2024
@HLWeil
Copy link
Member

HLWeil commented Sep 3, 2024

I guess it's an oversight based on the type already fitting the OntologyAnnotation from isa-json pretty well. Nonetheless it should be added to the profile for clarity.

@floWetzels
Copy link
Collaborator Author

Fixed by PR #35

@github-project-automation github-project-automation bot moved this to Done in ARCStack Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage This item is up for investigation.
Projects
ARCStack
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HLWeil @floWetzels