Added identifieres for Person and ScholarlyArticle #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLWeil
reviewed
May 27, 2024
profile/isa_ro_crate.md
Outdated
| @@ -248,9 +248,10 @@ It is based on [schema.org/ScholarlyArticle](https://schema.org/ScholarlyArticle | |||
| |headline|MUST|Text|| | |||
| |author|SHOULD|[schema.org/Person](https://schema.org/Person)|| | |||
| |url|SHOULD|URL|| | |||
| |identifier|SHOULD|Text or URL or [schema.org/PropertyValue](https://schema.org/PropertyValue)|One or many identifiers for this article like a DOI or PubMedID. Can be of type PropertyValue to indicate the kind of reference.| | |||
There was a problem hiding this comment.
Shouldn't sameAs be thrown out in favor of identifier?
There was a problem hiding this comment.
Could it be that you're mixing up Issues/PRs here? I can't follow you.
| @@ -248,9 +248,10 @@ It is based on [schema.org/ScholarlyArticle](https://schema.org/ScholarlyArticle | |||
| |headline|MUST|Text|| | |||
| |author|SHOULD|[schema.org/Person](https://schema.org/Person)|| | |||
| |url|SHOULD|URL|| | |||
| |identifier|SHOULD|Text or URL or [schema.org/PropertyValue](https://schema.org/PropertyValue)|One or many identifiers for this article like a DOI or PubMedID. Can be of type PropertyValue to indicate the kind of reference.| | |||
| |creativeWorkStatus|COULD|[schema.org/DefinedTerm](https://schema.org/DefinedTerm)|The status of the publication in terms of its stage in a lifecycle.| | |||
| |disambiguatingDescription|COULD|Text| | |||
There was a problem hiding this comment.
What is disambiguatingDescription referring to in this context?
There was a problem hiding this comment.
I don't remember exactly, but my guess would be the comments from ISA.
There was a problem hiding this comment.
Yes, you even mentioned it in Issue #3
|
Handling of names has now been adapted, concluding the discussion in #15 |
This was referenced Jun 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the identifier property to the profiles for Person and ScholarlyArticle. They should be used to describe a DOI, PubMedID or ORCID, see Issues #16 and #8.
Once the discussion reaches a conclusion, I will also change how names are depicted, see Issue #15.