Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation - Decouple updates to VirtualServerRoute from VirtualServer resource #6616

Open
4 of 17 tasks
Tracked by #5293
danielnginx opened this issue Oct 8, 2024 · 1 comment
Open
4 of 17 tasks
Tracked by #5293
Assignees
Labels
backlog Pull requests/issues that are backlog items refined Issues that are ready to be prioritized
Milestone

Comments

@danielnginx
Copy link
Collaborator

danielnginx commented Oct 8, 2024

Definition of Done

Development

  • Attach VirtualServerRoute to VirtualServer with label selector
  • Maintain backwards compatibility with existing implementation
  • Ensure VSR can change which VS it is linking to without changing the original VS
  • Ensure existing functionality of VirtualSever and VirtualServerRoute operates as expected
  • Unit tests are written to cover functionality delivered in the story.
  • Make sure that the unit test passes before creating a pull request.
  • Make sure that the test coverage stays optimal.
  • Run make lint locally before creating a PR.

Testing

  • Automated tests are written as part of the story.
  • Run “make lint-python“ from root
  • Acceptance criteria are met.
  • Stories are demonstrated to the team.
  • Product Manager accepts the story as done.
  • If a feature requires changes/extensions of the Helm chart, those shall be done as part of the story.

Release Notes & Documentation

  • PR is labeled appropriately so they display in GitHub release notes.
  • Create/update documentation related to the user story.
  • Create/update the example in our codebase when applicable.
@danielnginx danielnginx added the backlog Pull requests/issues that are backlog items label Oct 8, 2024
@shaun-nx shaun-nx added ready for refinement An issue that was triaged and it is ready to be refined refined Issues that are ready to be prioritized and removed ready for refinement An issue that was triaged and it is ready to be refined labels Oct 9, 2024
@shaun-nx shaun-nx changed the title Implementation - Make it easier to "attach" a VirtualServerRoute to a VirtualServer Implementation - Decouple updates to VirtualServerRoute from VirtualServer resource Oct 17, 2024
@shaun-nx shaun-nx added this to the v4.0.0 milestone Oct 17, 2024
@jjngx
Copy link
Contributor

jjngx commented Nov 25, 2024

Two examples for VSR and VS selector:

  1. One, default namespace
examples/custom-resources/vsr-selector-basic
├── README.md
...
  1. Multiple namespaces
examples/custom-resources/vsr-selector-multinamespace
├── README.md
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items refined Issues that are ready to be prioritized
Projects
Status: In Progress 🛠
Development

No branches or pull requests

4 participants