Merge pull request #199 from marcosfabietti/issue.#.196.inconsistent.…

…colours

R/ptd_spc_colours.R

@@ -13,16 +13,16 @@
 #'
 #' @export
 ptd_spc_colours <- function(
-    common_cause = "#7b7d7d",
-    special_cause_improvement = "#289de0", # blue
-    special_cause_neutral = "#361475", # purple
-    special_cause_concern = "#fab428", # orange
-    value_line = "#7b7d7d",
+    common_cause = "#a6a6a6",
+    special_cause_improvement = "#00b0f0", # blue
+    special_cause_neutral = "#490092", # purple
+    special_cause_concern = "#e46c0a", # orange
+    value_line = "#a6a6a6",
     mean_line = "#000000",
-    lpl = "#7b7d7d",
-    upl = "#7b7d7d",
+    lpl = "#a6a6a6",
+    upl = "#a6a6a6",
     target = "#de1b1b",
-    trajectory = "#361475") {
+    trajectory = "#490092") {
   structure(
     list(
       common_cause = common_cause,

README.Rmd

@@ -90,8 +90,8 @@ sub_set %>%
 In addition, you can use summary() function to get some basic statistics about your SPC data frame.
 The function prints the SPC options, and then returns the summarised results as a table:
 ```{r, eval=TRUE}
-summary<-sub_set %>%
-  ptd_spc(value_field = breaches, date_field = period, improvement_direction = "decrease",target=1200) %>%
+summary <- sub_set %>%
+  ptd_spc(value_field = breaches, date_field = period, improvement_direction = "decrease", target = 1200) %>%
   summary()
 ```
 

tests/testthat/test-ptd_create_ggplot.R

@@ -333,14 +333,14 @@ test_that("it sets the colour of the points based on the type", {
     )
 
   colours_neutral <- list(
-    common_cause              = "#7b7d7d", # grey
-    special_cause_neutral     = "#361475" # purple
+    common_cause              = "#a6a6a6", # grey
+    special_cause_neutral     = "#490092" # purple
   )
 
   colours_otherwise <- list(
-    common_cause              = "#7b7d7d", # grey
-    special_cause_improvement = "#289de0", # blue
-    special_cause_concern     = "#fab428" # orange
+    common_cause              = "#a6a6a6", # grey
+    special_cause_improvement = "#00b0f0", # blue
+    special_cause_concern     = "#e46c0a" # orange
   )
 
   # case 1: improvement_direction = neutral