Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable keyboard shortcuts #185

Merged
merged 87 commits into from
Dec 12, 2024
Merged

Conversation

nick42d
Copy link
Owner

@nick42d nick42d commented Nov 24, 2024

includes large refactor of event system

@nick42d nick42d marked this pull request as draft November 24, 2024 09:56
@nick42d
Copy link
Owner Author

nick42d commented Dec 4, 2024

TODOs:

  • Fix failing tests - note github actions failing too
  • Decide on an action parameter (e.g down(5))
  • Decide if actions should be an array
  • Deduplicate keycommand and keybind modules
  • Broaden implementation of Scrollable
  • Allow merging of default and non-default config.
  • Fix help display for: Missing mode names, contexts (if possible)
  • Add comment for where app should restrict access to actions.

@nick42d nick42d marked this pull request as ready for review December 8, 2024 13:27
@nick42d
Copy link
Owner Author

nick42d commented Dec 8, 2024

Before merging - fix issue with modal / dominant keybinds - not activating, and hack to activate resulted in loss of list keybinds.

Resolved: Help menu not displaying correctly.
Not resolved: Backspace not displayed correctly, help menu should take over keybinds

@nick42d nick42d merged commit 53e1d3e into main Dec 12, 2024
3 checks passed
@nick42d nick42d deleted the iss10-keyboard-shortcuts branch December 12, 2024 00:16
@nick42d nick42d mentioned this pull request Dec 12, 2024
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant