Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSI Installer #1

Open
3 tasks
JPHutchins opened this issue Oct 22, 2024 · 4 comments · May be fixed by #12
Open
3 tasks

Add MSI Installer #1

JPHutchins opened this issue Oct 22, 2024 · 4 comments · May be fixed by #12

Comments

@JPHutchins
Copy link
Contributor

JPHutchins commented Oct 22, 2024

I have some experience configuring wix v4 from a tutorial that I am working on: https://github.com/JPHutchins/python-distribution-example/tree/main/distribution/windows

TODO:

  • see what is most common for other Rust projects
  • list the required features - e.g. option to start in tray on windows startup?
  • consensus for framework

This feature belongs to the milestone "winget / microsoft store".

@JPHutchins
Copy link
Contributor Author

JPHutchins commented Oct 22, 2024

BTW, it seems like this application has a nice design for simplicity which is that persisted state is owned by USBIPD-win, not this application. Which makes the portable work great!

I noticed on the roadmap some thoughts about configs ... definitely the MSI makes that doable - it means that config files are saved under the AppData folder. Configs would not be lost when the application is updated (via winget, manual MSI run, or Microsoft Store).

Would be good to confirm that this is a requirement in the long run.

@JPHutchins
Copy link
Contributor Author

I see this https://github.com/volks73/cargo-wix. But my gut feeling is that the abstraction may more problems than it solves. WiX is already an abstraction, why not use it directly?

@JPHutchins
Copy link
Contributor Author

JPHutchins commented Oct 28, 2024

Here's an MSI build. Related to #8 , opt-level is 0.

WSL USB Manager.zip

The MSI is only 864KB, very impressive!

@nickbeth
Copy link
Owner

nickbeth commented Nov 7, 2024

If this is something you'd like to implement, I'm all for it. As I've said in another issue, sadly I don't have the time to work on this anymore, mostly because I switched to Fedora Linux and I don't need this app anymore. I'll still try to make some time for reviewing and merging PRs, so if you want you can go ahead and create a PR for this.

@JPHutchins JPHutchins linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants