Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No frames in output #501

Closed
1 task done
nicolay-r opened this issue Jul 18, 2023 · 0 comments
Closed
1 task done

No frames in output #501

nicolay-r opened this issue Jul 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 18, 2023

This is related to #465 task.
All the writers are fetch columns from the get_columns_list_with_types.
Which is a SampleColumnsProvider at the moment and a default provider.
The latter does not include frames.

For the following scenario:

python3 -m arekit_ss.sample --writer csv --source ruattitudes --sampler nn --src_lang ru --dest_lang ru --docs_limit 10 --text_parser nn --output_dir ./_out/a/ --no-vec

We have an output without annotated frames

sample-train-0.csv""

In AREkit==0.23.1 temporary workaround is to provide these colums as a parameter:

RowCacheStorage(force_collect_columns=[FrameVariantIndices, FrameConnotations])

But for json, the related formatter does not support external columns. This might be treated as bug

@nicolay-r nicolay-r self-assigned this Jul 18, 2023
@nicolay-r nicolay-r added the bug Something isn't working label Jul 18, 2023
@nicolay-r nicolay-r transferred this issue from nicolay-r/arekit-ss Jul 21, 2023
@nicolay-r nicolay-r added the task label Jul 21, 2023
@nicolay-r nicolay-r mentioned this issue Jul 22, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task
Projects
None yet
Development

No branches or pull requests

1 participant