New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong place to put maxRowsInMemory #863

Open

2 tasks done

voidlol opened this issue Jun 12, 2024 · 0 comments

voidlol commented Jun 12, 2024

Am I using the newest version of the library?

I have made sure that I'm using the latest version of the library.

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

https://github.com/crealytics/spark-excel/blob/main/src/main/scala/com/crealytics/spark/excel/v2/ExcelHelper.scala#L110

Here you are passing maxRowsInMemory option in bufferSize which is wrong :)

Expected Behavior

StreamingReader.builder().rowCacheSize(maxRowsInMemory)

Steps To Reproduce

No response

Environment

- Spark version:
- Spark-Excel version:
- OS:
- Cluster environment

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment