Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying passwords from duplicated items, references password of original item instead of duplicate #4434

Open
whosht opened this issue Oct 29, 2024 · 2 comments

Comments

@whosht
Copy link

whosht commented Oct 29, 2024

Steps to reproduce

  1. Login
  2. Goto any writeable folder
  3. Click New item
  4. Fill in at least Label, Login and Password
  5. Click on Save
  6. Click on the new item to view all details
  7. In the top action list click on Copy to add a copy of the item
  8. Change value of New label
  9. Click on Perform
  10. Click on Edit
  11. Change Password
  12. Click Save
  13. From the folder item overview, hover over the item created at step 5 and select symbol to Copy password
  14. Paste the password somewhere
  15. From the folder item overview, hover over the item created at step 9 and modified at step 12 and select symbol to Copy password
  16. Paste the password somewhere
  17. From the folder item overview, click the item created at step 5 to view the details and Copy the password from there.
  18. Paste the password somewhere
  19. From the folder item overview, click the item created at step 9 and modified at step 12 to view the details and Copy the password from there.
  20. Paste the password somewhere

Expected behaviour

Passwords pasted at step 14 and 16 should differ.
Passwords pasted at step 18 and 20 should differ.
Passwords pasted at step 14 and 18 should be the same.
Passwords pasted at step 16 and 20 should be the same.

Actual behaviour

Passwords pasted at step 14 and 16 are the same.
Passwords pasted at step 18 and 20 are different.
Passwords pasted at step 14 and 18 are the same.
Passwords pasted at step 18 and 20 are different.

Server configuration

Operating system: Debian 12

Web server: Apache

Database: mariadb

PHP version: 8.2.24

Teampass version: 3.1.2.134

Teampass configuration file:

Updated from an older Teampass or fresh install:
PLEASE attach to this issue the file /includes/config/tp.config.php.

Client configuration

Browser: Brave

Operating system: Windows

Logs

Web server error log

Insert your webserver log here

Log from the web-browser developer console (CTRL + SHIFT + i)

Insert the log here and especially the answer of the query that failed.
@whosht
Copy link
Author

whosht commented Oct 29, 2024

@nilsteampassnet Might be related to item_key of a password entry as I found out that duplicated items using the copy function all have the same value for item_key as the original item.

@FengZh61
Copy link
Contributor

#4421 Fixed duplicate item_key issue when copying items.Please check if the version you are using fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants