Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace danger-ruby with danger-kotlin #494

Open
luongvo opened this issue Jul 21, 2023 · 1 comment
Open

Replace danger-ruby with danger-kotlin #494

luongvo opened this issue Jul 21, 2023 · 1 comment

Comments

@luongvo
Copy link
Member

luongvo commented Jul 21, 2023

Why

We're using danger-ruby which requires setting up Ruby env for execution while mainly working with Android/Kotlin env.

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.7'
- name: Cache gems
uses: actions/cache@v2
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-
- name: Install Bundle and check environment versions
run: |
echo 'Install Bundle'
bundle config path vendor/bundle
bundle install
echo 'Check environment setup versions'
ruby --version
gem --version
bundler --version

Using danger-kotlin would bring better language integration & workflow optimization.

Who Benefits?

Developers

@luongvo
Copy link
Member Author

luongvo commented May 28, 2024

@ryan-conway Due to an unresolved issue, move this back to "Ice-box" 🤒

@ryan-conway ryan-conway removed this from the 3.29.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants