Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Flexibilize "sophisticated" pepolar to allow monomodal execution #3393

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 3, 2024

Changes proposed in this pull request

Documentation that should be reviewed

@oesteban oesteban requested a review from effigies November 3, 2024 09:02
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (2e4f921) to head (729b5b9).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
fmriprep/workflows/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3393   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files          57       57           
  Lines        4231     4231           
  Branches      455      455           
=======================================
  Hits         3049     3049           
  Misses       1067     1067           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

effigies commented Nov 3, 2024

What use case is this intended to support?

@oesteban
Copy link
Member Author

oesteban commented Nov 3, 2024

I have a dataset with all four AP/PA/LR/RL EPIs. This should be easy to handle by topup.

@effigies
Copy link
Member

effigies commented Nov 3, 2024

What about len(suffixes) >= 2, then? Or we could drop the length check altogether and rely on sdcflows to not create estimators with too few inputs.

@oesteban
Copy link
Member Author

oesteban commented Nov 3, 2024

What about len(suffixes) >= 2, then? Or we could drop the length check altogether and rely on sdcflows to not create estimators with too few inputs.

The idea is that the four images are of the same modality while also allowing for epi + bold (which should be capture by the other condition, and disallow more than 2 images)

@effigies
Copy link
Member

effigies commented Nov 3, 2024

Got it. Let's add a comment, as I'm sure I'll forget.

@oesteban
Copy link
Member Author

oesteban commented Nov 3, 2024 via email

@effigies effigies merged commit 08fecee into master Nov 3, 2024
10 of 11 checks passed
@effigies effigies deleted the fix/sdc-sophisticated-pepolar branch November 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants