Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use removeprefix instead of lstrip or ternary operator #3409

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

effigies
Copy link
Member

We had some .lstrip()s that should be removeprefix() as well as some pre-removeprefix() hacks of the form s[len(prefix):] if s.startswith(prefix) else s.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.24%. Comparing base (0218f4f) to head (5c55606).
Report is 4 commits behind head on maint/24.1.x.

Files with missing lines Patch % Lines
fmriprep/utils/bids.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0218f4f) and HEAD (5c55606). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0218f4f) HEAD (5c55606)
7 4
Additional details and impacted files
@@                Coverage Diff                @@
##           maint/24.1.x    #3409       +/-   ##
=================================================
- Coverage         71.78%   48.24%   -23.54%     
=================================================
  Files                57       57               
  Lines              4256     4255        -1     
  Branches            458      458               
=================================================
- Hits               3055     2053     -1002     
- Misses             1086     2133     +1047     
+ Partials            115       69       -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 433d42d into nipreps:maint/24.1.x Dec 11, 2024
8 of 16 checks passed
@effigies effigies deleted the enh/removeprefix branch December 11, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant