Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Add safeguards to query formulation, exception handling #50

Merged
merged 4 commits into from
Nov 17, 2023
Merged

FIX: Add safeguards to query formulation, exception handling #50

merged 4 commits into from
Nov 17, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Nov 17, 2023

  • Adds enum QueryParamType, which is assigned to each query parameter. This allows calling json.dumps on text fields to ensure troublesome characters are properly escaped.
  • Fallback to Exception.__str__ to retrieve message if Exception.args is empty.

mgxd
mgxd commented Nov 17, 2023
View reviewed changes
migas/operations.py Outdated Show resolved Hide resolved
@mgxd mgxd merged commit 880920a into nipreps:main Nov 17, 2023
2 checks passed
@mgxd mgxd deleted the fix/query-fmt branch November 17, 2023 22:36
@mgxd mgxd mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgxd