Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow required value in reportlet configs. #122

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rwblair
Copy link
Contributor

@rwblair rwblair commented May 17, 2024

Interprets 'required' key when present in a reportlets config dictionary.
If its true and no files/figures were found then raise an exception. Report indexer will catch these exceptions and raise a single exception at the end of its run with all of the collected reportlet exceptions.

fixes #78

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (60fd854) to head (626b07b).

Current head 626b07b differs from pull request most recent head 131d1a5

Please upload reports for the commit 131d1a5 to get more accurate results.

Files Patch % Lines
nireports/assembler/report.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   58.34%   59.00%   +0.66%     
==========================================
  Files          22       23       +1     
  Lines        2096     2120      +24     
  Branches      365      367       +2     
==========================================
+ Hits         1223     1251      +28     
+ Misses        788      786       -2     
+ Partials       85       83       -2     
Flag Coverage Δ
unittests 58.80% <90.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rwblair and others added 5 commits October 4, 2024 16:23
If its true and no files/figures were found then raise an exception.
Report indexer will catch these exceptions and raise a single exception
at the end of its run with all of the collected reportlet exceptions.
@effigies effigies force-pushed the enh/mandatory_config branch from 7730215 to e9b3a82 Compare October 4, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a notion of "mandatory" reportlet/section in the bootstrap configuration file
2 participants