Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 27 changed behavior of extras path #57

Open
juzim opened this issue Feb 23, 2017 · 2 comments
Open

PR 27 changed behavior of extras path #57

juzim opened this issue Feb 23, 2017 · 2 comments

Comments

@juzim
Copy link
Contributor

juzim commented Feb 23, 2017

I just saw that #27 changed the behavior of the path.extras value.

Before it was used on it's own equally to the download path:
directory = self.__config.get('path', 'path.extras')
now it's appended
` if self.__config.has_option('path', 'path.group'):

        folder_name = self.info['title'].encode('ascii', 'ignore').replace(' ', '_') + \
                      self.info['author'].encode('ascii', 'ignore').replace(' ', '_')

        directory = base_path + join(self.__config.get('path', 'path.ebooks'), folder_name,         self.__config.get('path', 'path.extras'))
    else:
        directory = base_path + self.__config.get('path', 'path.extras')`

@lszeremeta could you have a look? Since the extras be quite large, it should be possible to move them somewhere else.

Can you also add your changes to the example prod file and the readme? It took me quite some time to figure out what was happening.

Otherwise, if we decide which behavior we want to keep, I can refactor it while working on #56

@juzim juzim changed the title PR 27 changed behaviour of extras path PR 27 changed behavior of extras path Feb 23, 2017
@niqdev
Copy link
Owner

niqdev commented Feb 24, 2017

@juzim hi I can't test the new changes now..I'll merge the pr next week. Is it stable or require more changes? Thanks

@juzim
Copy link
Contributor Author

juzim commented Feb 24, 2017

I have closed the PR.

I was hoping that @lszeremeta might take a look himself because I don't have much time at the moment.

When we decide that we want the extras path independent from the download path, I will include the changes in my PR. I also need this for the long awaited download all functionality that willmight be done soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants