Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'TTP build flag [bid:]' message with more meaningful one #204

Open
jasdevsidhu12 opened this issue Jul 4, 2019 · 5 comments
Open
Assignees

Comments

@jasdevsidhu12
Copy link

How should I replace the message(picture below)'TTP build flag' to 'build fail' or 'build pass'
image

@CodeMonk
Copy link
Collaborator

Sooo -- the build flag is not really saying pass or fail, it's saying that THAT particular commit has been built.

I'm pretty sure it gets added to the PR when the build STARTS, so that extra builds are not kicked off. The result (pass, fail, etc) is stored by atlassian somewhere in the build later.

But, I do agree that TPP build flag is awful. I'm happy to change that particular text to something more meaningful, like BitbucketPullRequestBuilder: build:

@jasdevsidhu12
Copy link
Author

Thank you for the reply @CodeMonk ,

Yeah I would love to have the message "BitbucketPullRequestBuilder: build:" rather than "TTP build flag".

I just wish there was setting in the PR plugin to display the message back to the user in BitBucket PR comment section whether the build pass or fail.

@CodeMonk
Copy link
Collaborator

Yeah, you can make the builder approve the build, but there isn't really an option to add a comment.

@CodeMonk
Copy link
Collaborator

Tell ya what. I'm going to re-open this one to have the build flag configurable-ish, or at least change it.

Please open another issue about commenting with build results - I think that would be a nice enhancement.

@CodeMonk CodeMonk reopened this Jul 23, 2019
@CodeMonk CodeMonk self-assigned this Jul 23, 2019
@ncarrier
Copy link

ncarrier commented Jan 23, 2020

Hello,
Would it be possible to have a direct link to the actual job's build in the comment?
That would allow to quickly check why a PR build failed.

And BTW, the hash should be that of the commit being built IIUC?
That's weird, I can't find this hash in my project's history...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants