Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hamburger modal hides behind page navbar #130 #173

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: Hamburger modal hides behind page navbar #130 #173

wants to merge 1 commit into from

Conversation

som-04
Copy link
Contributor

@som-04 som-04 commented May 5, 2024 •
edited by GetPsyched
Loading

Closes #130

GetPsyched
GetPsyched requested changes May 7, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't be updating z values inplace but rather in tailwind.config.ts

@som-04
Copy link
Contributor Author

som-04 commented May 8, 2024 •
edited
Loading

image
image

it's happening when kept blank, numeric values aren't changing anything.
so can we just remove z index for the drop down?

@GetPsyched
Copy link
Member

Are you putting the values as a string? See how the others are put:

nitkkr/tailwind.config.ts

Lines 53 to 55 in 1f9bf39

modal: '90',
nav: '80',
toast: '100',

The current z-nav also works with this. There's no possible way it doesn't work as long as you use the same syntax with the same types as this.

@som-04
Copy link
Contributor Author

som-04 commented May 8, 2024

yeah the values were entered as a string.
it goes behind on entering any value, but obviously we can't remove nav, so... can we just remove z-nav from here?

nitkkr/components/image-header.tsx

Line 53 in 1f9bf39

'sticky top-6 z-nav mx-auto w-fit rounded-full',

@GetPsyched
Copy link
Member

We would not remove z-nav, it's there for a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GetPsyched GetPsyched GetPsyched requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hamburger modal hides behind page navbar
2 participants
@som-04 @GetPsyched