-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added # button to heading #155
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues:
- Should be a ease-in-out animation with some gap between the hash and text
- Hovering on the glyphs should also trigger the hash button
cac2be2
to
bac50da
Compare
1cc1235
to
9854263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its firefox again, I could have just used a span(dont know which is better semantically) |
4afd62c
to
9b30c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some styling fixes remain
you removed the comp from the button, it there any problem with that cause that was the best fix to the problem that got introduced now |
|
Uh, @heydoyouknowme0? |
If we want to make the gap unclickable we can just add a margin instead of a padding, no? |
Nope then hover isn't registered |
No description provided.