Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement /nar/{store_hash}-{nar_hash}.nar endpoint #122

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

chayleaf
Copy link

@chayleaf chayleaf commented Jul 31, 2023

This should partially fix #120. I've yet to test this.

@Mic92
Copy link
Member

Mic92 commented Aug 1, 2023

Is this now used by default for all queries? Should we adapt our test to also test the new nix version?

@chayleaf
Copy link
Author

chayleaf commented Aug 1, 2023

I have no idea, I tried looking in Nix code but couldn't find anything related to it. All of it appears to be code for the old behavior, but Harmonia wouldn't work for me and this endpoint missing was one of the errors.

I don't think this single endpoint would be enough to completely establish new Nix compatibility, testing new Nix versions would be a good starting point.

@chayleaf
Copy link
Author

chayleaf commented Aug 3, 2023

I've found it thanks to the discussion in the linked issue. The problem is that due to previous nix-serve usage Nix cached this line of narinfo, causing it to query a different URL for as long as the narinfo was still cached. It still isn't clear why <hash>-<name>.narinfo was being queried for other users however.

In that case, testing this with new Nix versions wouldn't actually do anything.

The issue isn't completely resolved, but I'll unmark this as draft.

@chayleaf chayleaf marked this pull request as ready for review August 3, 2023 20:58
@Mic92
Copy link
Member

Mic92 commented Aug 6, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Aug 6, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 64414da

@mergify mergify bot merged commit 64414da into nix-community:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My nix queries /nar/<hash>-<name>.narinfo, not just /<hash>.narinfo
2 participants