Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show jobset & eval details, rewrite in rust #51

Merged
merged 8 commits into from
Nov 25, 2024
Merged

feat: show jobset & eval details, rewrite in rust #51

merged 8 commits into from
Nov 25, 2024

Conversation

bryango
Copy link
Collaborator

@bryango bryango commented Nov 10, 2024 •
edited
Loading

Summary: show jobset & eval details, rewrite in rust, bump to v2. Note that:

  • Obviously, you don't have to merge this at all 😆 as the patch significantly complexifies the codebase, making it harder to maintain or review (though rust does make it easier to package the program and protects it against bit rot, compared to python).
  • The rewrite in rust is not justified, it's just a personal preference. As an amateur programmer, when I need some functionality (e.g. colored texts, aligned tables), I simply add a library 😆 In rust I cargo add when necessary without much worrying (after checking the reputation of the depended crate, of course), while in python, I do not feel as comfortable to just pull in random dependencies.
  • I am absolutely okay if the final decision is to not merge this! I just want to share it upstream as this extended v2 version has been serving me well.

features

  • Print recent evaluations of the jobset if no package is specified
    Jobset status
  • Add an --eval flag for information about a specific evaluation
    Eval status
  • Infer the current stable Nixpkgs release (e.g. 24.05) with a hack
    Stable channel
  • Support standard channel names (e.g. nixos-unstable)
  • Generate shell completions with --shell-completion SHELL
  • Print nicely formatted, colored and aligned tables

@bryango
build(deps): bump flake.lock
e501ba5 
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/97b17f32362e475016f942bbdfda4a4a72a8a652?narHash=sha256-UcsnCG6wx%2B%2B23yeER4Hg18CXWbgNpqNXcHIo5/1Y%2Bhc%3D' (2024-01-29)
  → 'github:NixOS/nixpkgs/c8a17040be4a20b29589cb4043a9e0c36af1930e?narHash=sha256-7NBJm1jfMeAowE1J2oljYqWVvI9X7FyyxBY4O8uB/Os%3D' (2024-10-06)
• Updated input 'flake-utils':
    'github:numtide/flake-utils/1ef2e671c3b0c19053962c07dbda38332dcebf26?narHash=sha256-uNRRNRKmJyCRC/8y1RqBkqWBLM034y4qN7EprSdmgyA%3D' (2024-01-15)
  → 'github:numtide/flake-utils/c1dfcf08411b08f6b8615f7d8971a2bfa81d5e8a?narHash=sha256-X6rJYSESBVr3hBoH0WbKE5KvhPU5bloyZ2L4K60/fPQ%3D' (2024-09-17)
• Updated input 'poetry2nix':
    'github:nix-community/poetry2nix/e0b44e9e2d3aa855d1dd77b06f067cd0e0c3860d?narHash=sha256-puYyylgrBS4AFAHeyVRTjTUVD8DZdecJfymWJe7H438%3D' (2024-01-12)
  → 'github:nix-community/poetry2nix/8e965fd42c0da4357c53d987bc62b54a954424da?narHash=sha256-RefXB9kqYch6uGT%2Bmo6m3KTbNerfbDYz%2BEqkLb6YBbs%3D' (2024-10-07)
• Updated input 'poetry2nix/nix-github-actions':
    'github:nix-community/nix-github-actions/4bb5e752616262457bc7ca5882192a564c0472d2?narHash=sha256-yPncV9Ohdz1zPZxYHQf47S8S0VrnhV7nNhCawY46hDA%3D' (2023-11-03)
  → 'github:nix-community/nix-github-actions/622f829f5fe69310a866c8a6cd07e747c44ef820?narHash=sha256-uPlLYH2S0ACj0IcgaK9Lsf4spmJoGejR9DotXiXSBZQ%3D' (2024-07-04)
• Updated input 'poetry2nix/treefmt-nix':
    'github:numtide/treefmt-nix/e82f32aa7f06bbbd56d7b12186d555223dc399d1?narHash=sha256-3h3EH1FXQkIeAuzaWB%2BnK0XK54uSD46pp%2BdMD3gAcB4%3D' (2023-11-12)
  → 'github:numtide/treefmt-nix/4446c7a6fc0775df028c5a3f6727945ba8400e64?narHash=sha256-xpRqITAoD8rHlXQafYZOLvUXCF6cnZkPfoq67ThN0Hc%3D' (2024-10-03)
@bryango
build(deps): python 3.11 -> 3.12 & poetry.lock
723b5f6
@bryango
feat: print jobset & evals, riir
a66c185
@bryango
feat: print shell completions
1d8d9d0
@bryango
feat: hack to provide channel completions for zsh
e22f246
@bryango
feat(ci): use magic nix cache
0687aa4 
uses: DeterminateSystems/magic-nix-cache-action@v8
@bryango
fix: improve internal naming of objects
11bdc18 
Also, show empty / unknown delta as "Δ ~" instead of "Δ ?".
@makefu
Copy link
Member

makefu commented Nov 20, 2024

Hey! At first whoa, thanks alot for your effort! I saw your PR 2 weeks ago but i was just a bit overwhelmed :) i will check out your rebuild and give back some feedback afterwards!

@makefu
Copy link
Member

makefu commented Nov 20, 2024

The Pull Request looks good and i would like to merge the PR under sole condition that you would have to become one of the maintainers of hydra-check with the power (and responsibility) to handle issues and merge requests together with me and @Artturin

@Artturin i hope you are also fine with that 💯

@bryango
Copy link
Collaborator Author

bryango commented Nov 22, 2024

The Pull Request looks good and i would like to merge the PR under sole condition that you would have to become one of the maintainers of hydra-check with the power (and responsibility) to handle issues and merge requests together with me and Artturin

I am perfectly fine with that! It would be an honor! Thank you!

In the latest push I added two more commits: one is a rename of some internal objects (along with extra documentations) such that it would be clearer for future contributors, and the other is an improvement of the --eval cli processing such that one can simply do e.g. hydra-check --eval rustc for the latest eval filtered by rustc.

@makefu makefu merged commit e8291af into nix-community:master Nov 25, 2024
4 checks passed
@makefu
Copy link
Member

makefu commented Nov 25, 2024

@bryango thanks a lot for your efforts! I've added you as a maintainer to the project.

@bryango
Copy link
Collaborator Author

bryango commented Nov 25, 2024

Thank you very much! If there is any issue, feel free to ping me anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryango @makefu