Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection does not work under zsh. #165

Closed
DaKingof opened this issue Jun 24, 2023 · 13 comments
Closed

Selection does not work under zsh. #165

DaKingof opened this issue Jun 24, 2023 · 13 comments
Labels
question Further information is requested

Comments

@DaKingof
Copy link

When attempting to select the method used with tab it only comes up with option 0 on zsh. When I try typing in another option it just says hit tab to see options. The only thing I can do is hit enter. Typing any number 0-5 does nothing but tell me to hit tab.

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

This is probably not an issue with zsh. There might be only 1 option if the only thing showing up is option 0, and nix-init tells you to press tab when you are not picking an available option, and pressing enter commits the selection.

I agree this is not the most intuitive interface, which is why I am planning on a redesign for nix-init's UI. Feel free to drop a comment in #72 on what you think would be a better alternative.

@DaKingof
Copy link
Author

It goes through if I hit enter without selecting anything. But when I select zero it tells me to select 0-5. Same with any other number. I'm not sure what would be better, but I'll definitely test when you've decided on a new interface to see if it works then. Thank you.

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

But when I select zero it tells me to select 0-5

hmm, that sounds like a bug to me, which repository are you working with? I'll see if I can reproduce this

@DaKingof
Copy link
Author

I'm on unstable. If you want my nixconfig I can send it to you.

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

ah, by repository I mean what is the URL of the program you are trying to package, i.e. what did you put in when nix-init asked Enter url

@DaKingof
Copy link
Author

DaKingof commented Jun 24, 2023

Ohh! I was trying out https://github.com/btobolaski/text-generation-webui to locally host some LLM's for testing.

@DaKingof
Copy link
Author

DaKingof commented Jun 24, 2023

image

This is what I see here.

Just tried on the original at https://github.com/oobabooga/text-generation-webui and I get the same issue.

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

This is what I got too, what happens if you press enter and then enter here?

@DaKingof
Copy link
Author

It creates the deviation, but it's a python project so it's incorrect.

{ lib
, stdenv
, fetchFromGitHub
}:

stdenv.mkDerivation rec {
  pname = "text-generation-webui";
  version = "installers";

  src = fetchFromGitHub {
    owner = "oobabooga";
    repo = "text-generation-webui";
    rev = version;
    hash = "sha256-18+Ed2+oNsPDT9VZgCCpXFW9TEokhJpoQzTVllCS7Jw=";
  };

  meta = with lib; {
    description = "A gradio web UI for running Large Language Models like LLaMA, llama.cpp, GPT-J, Pythia, OPT, and GALACTICA";
    homepage = "https://github.com/oobabooga/text-generation-webui";
    license = licenses.agpl3Only;
    maintainers = with maintainers; [ ];
  };
}

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

This is expected since it doesn't use a standard python packaging method. nix-init is only able to detect the python if the repository contains setup.py or pyproject.toml, this is also the only way buildPythonApplication from nixpkgs can work AFAIK. So if you were to manually package it, you would probably also need to use stdenv.mkDerivation

@DaKingof
Copy link
Author

I see. That makes sense...so it's looking at the package and determining the other options aren't valid based on the file structure? So not a bug?

I guess I'll have to figure out how to manually make this deriviation from here then.

@figsoda
Copy link
Member

figsoda commented Jun 24, 2023

That makes sense...so it's looking at the package and determining the other options aren't valid based on the file structure?

Yep

@figsoda figsoda added the question Further information is requested label Jun 24, 2023
@DaKingof
Copy link
Author

DaKingof commented Jun 24, 2023

Alright. Thank you very much for the help/assistance and your work on this project. I'll close this now since it's not a bug.

Looking forward to the redesign and seeing where this goes! Have a wonderful weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants