Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify CMake antipattern of putting CMakeLists.txt in src subfolder #53

Open
MatthewCroughan opened this issue Mar 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MatthewCroughan
Copy link

Below are two examples of projects that are easy to package with nix-init, except the CMakeLists.txt are wrongly stored in the src/ subfolder of the project, which also confuses Nix's CMake hooks. All I had to do to compile these projects after running nix-init was

  1. add cmake to nativeBuildInputs
  2. add `preConfigure = "cd src";

It's possible that this case could be caught by nix-init

@figsoda figsoda added the enhancement New feature or request label Mar 2, 2023
@SomeoneSerge
Copy link

Maybe this could be generalized to cargo.toml and probably others: https://github.com/huggingface/safetensors

@figsoda
Copy link
Member

figsoda commented Apr 15, 2023

Also see #72 (comment), I think it's a good idea to have an option to look for these files in sub-directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants