-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/aerial: init #2559
base: main
Are you sure you want to change the base?
plugins/aerial: init #2559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues.
Minor issues:
- most of the custom types have no raw-lua support
- do we really need this many settings options? 😓
settingsOptions = | ||
let | ||
size = with types; either ints.unsigned (numbers.between 0.0 1.0); | ||
listOfSize = with types; either size (listOf size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always supposed to be a 2-elem list? Should we be using our custom listOfLen
type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this has no raw-lua support
# Several options can have a single value, or a filetype-value mapping. | ||
mkTypeOrAttrsOfType = | ||
type: default: description: | ||
defaultNullOpts.mkNullable (with types; either type (attrsOf type)) default description; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has no "raw" lua support, either at the top-level or at any elem-types.
Add support for aerial.nvim, a plugin for a code outline window.
Fixes #2514