Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in Internet Explorer #20

Open
redmunds opened this issue Sep 22, 2014 · 2 comments
Open

Doesn't work in Internet Explorer #20

redmunds opened this issue Sep 22, 2014 · 2 comments

Comments

@redmunds
Copy link
Collaborator

Initial page loads, but almost nothing else works in IE. I'm using Version 11.0.9600.17239 on Win7.

IE does not update even after saving page in Brackets. Interesting that if you Reload page from IE it pickups changes -- even unsaved changes in Brackets! So, it seems like text is getting updated in browser, but browser is not refreshing.

@sebaslv
Copy link
Contributor

sebaslv commented Sep 25, 2014

What I've found so far is that at least there is an issue related to how RemoteFunctions is removing elements. It uses node.remove() in a couple of places which seems to be not supported by IE. By replacing it with node.parentNode.removeChild(node);, I got HTML and CSS editing working on my IE version 10.0.92000.17054. We had a similar issue with running this on Android WebView on versions previous to 4.4 which are not based on Chromium.

Now, I'm not sure where to land this fix since RemoteFunctions is part of brackets core. Should we copy the entire file to this repo? Is it probably good time to analyze how we would switch between the current implementation of LiveDevelopment and this new one once it gets stabilized?

@redmunds
Copy link
Collaborator Author

I think it's best to do feature detection (as opposed to browser detection), something like:

    if (node.remove) {
        node.remove();
    } else if (node.parentNode && node.parentNode.remove) {
        node.parentNode.remove();
    } else {
        // ???
    }

I'd be ok with merging something like that into brackets core.

Is it probably good time to analyze how we would switch between the current implementation of LiveDevelopment and this new one once it gets stabilized?

Yes!

cc @dangoor @busykai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants