Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure v2.5 #111

Closed
22 of 23 tasks
jokoho48 opened this issue Apr 15, 2020 · 10 comments
Closed
22 of 23 tasks

Restructure v2.5 #111

jokoho48 opened this issue Apr 15, 2020 · 10 comments
Milestone

Comments

@jokoho48
Copy link
Collaborator

jokoho48 commented Apr 15, 2020

The Restructure is meant to clean the file/code structure and move functions that are not just used by one Module and are not module specific into the main module. while that we also should clean and move duplicated stringtable entries into main to keep the stringtables as small as possible.

Functions

  • Debug?
    • DebugLog
    • DebugObjectColor
  • doCallout
  • gesture -> doGesture
  • doSmoke
  • doUGL
  • eventCallback
  • findBuilding
  • findCover
  • nearbyFriendly -> findNearbyFriendly
  • findOverwatch
  • findReadyUnits
  • isAlive
  • indoor -> isIndoor
  • isNight

Settings

  • Debug
  • Gesture
  • Callout

Stringtable

  • Debug Settings
  • Gesture Settings
  • Callout Settings
  • Unify Duplicated Entrys
@nk3nny
Copy link
Owner

nk3nny commented Apr 15, 2020

Stringtalbe ;)

Lets do a team speak meeting

@nk3nny
Copy link
Owner

nk3nny commented Apr 16, 2020

From meeting

  1. Look into adding relevant ACE3 animations when available (for gestures and so on)
  2. Consider also restructuring fsm
  3. Suppressive fire module
  4. Supportive CAS
  5. Initial AI profiles (Forward Observer, Recon, Militia/Rebels)
  6. Add option for 'autonomous reorganisation' i.e., autonomous formation changes
  7. Add close autonomous manoeuvres for seizing nearby buildings
  8. Look into adding post-battle assessment stage

@nk3nny
Copy link
Owner

nk3nny commented Apr 19, 2020

With restructure consider renaming:

  • fnc_gesture to fnc_doGesture
  • fnc_coward to fnc_isCoward
  • fnc_hideInside to fnc_doHide
  • fnc_checkBody to fnc_doCheckBody

Thoughts?

@nk3nny
Copy link
Owner

nk3nny commented Apr 19, 2020

Reminder for self:

Consider implementing a mod-wide disabling of enableAttack to give us better fine control of AI attack patterns. Units with the currentCommand "ATTACK" become wildly moody and difficult to manoeuvre with.

This would be an invasive change.

https://community.bistudio.com/wiki/enableAttack
https://community.bistudio.com/wiki/currentCommand

@nk3nny
Copy link
Owner

nk3nny commented Jun 15, 2020

Memo to self:
Possibly add a CBA setting which stops units given WP/Modules from changing ACE3 style headless locality swapping.

this setVariable ["acex_headless_blacklist", true];

https://ace3mod.com/wiki/frameworkx/headless-framework.html

@nk3nny
Copy link
Owner

nk3nny commented Jun 15, 2020

Add module which give a group the vanilla guard waypoint (and whatever enhancements we can provide or add to it). Possibly adding a second module to define new guard positions.

@nk3nny
Copy link
Owner

nk3nny commented Sep 23, 2020

Small bugs:

  • Units set to careless should exit FSM (modify isForced and brainForced.sqf
  • It seems units are sometimes "locked" into a dodge cycle. This causes them to permanently backpedal. Will investigate
  • Investigate "target_f" or "skeet_f" in doUGL.sqf -- use "CBA_buildingPos"

Suppression
Units are currently very suppression-happy. Will consider changing brainEngage to only allow "Can Fire" to trigger doSuppression, rather than also "Enemy Near".

Have noticed AI will sometimes suppress quite happily at nothings. Though this may be related to other features.

lambs_danger_CQB
The group variable "lambs_danger_CQB" is I think poorly named. A better reflection of it being a sympathetic storeroom of positions to check or suppress would be "lambs_danger_memory" or similar. Perhaps write a function which makes reading and modifying the variable easier.

@nk3nny
Copy link
Owner

nk3nny commented Feb 8, 2021

Todo

  • rename shareInformation to doShareInformation
  • rename shareInformationRange to getShareInformationParams
  • move all do functions to /main
  • update .fsm to follow new variable names (groupMemory)
  • move relevant /settings to /main folder
  • move relevant EHs to main/wp
  • use internal EHs in /danger to readd reinforcement system
  • optionally add wrappers for moved EHs
  • Forwards FRQ: Forward Danger Event #115
  • fix known bugs (see below)
  • write changelog
  • test release
  • release

Found bugs - 08.02.21

  • vehicle.sqf -- should exit if unit unconscious
  • vehicleSuppress.sqf -- error with AGLtoASL handling
  • feature: check "enableSimulation" in available artillery
  • debug draw setting showing errors @jokoho48 ?
  • .editorconfig. bonanza

Discarded
Add settings for groupMemory feature <-- will require a restructure of a host of other features for very small gains.

@nk3nny
Copy link
Owner

nk3nny commented Feb 9, 2021

#174

@nk3nny nk3nny changed the title Restructure Restructure v2.5 Feb 9, 2021
@nk3nny nk3nny added this to the 2.5.0 milestone Feb 9, 2021
@nk3nny nk3nny pinned this issue Feb 9, 2021
@nk3nny
Copy link
Owner

nk3nny commented Feb 10, 2021

Internal variable name change: lambs_main_isArtillery

  • updated brainVehicle.sqf
  • updated leaderStaticDeploy

@nk3nny nk3nny closed this as completed Apr 16, 2021
@jokoho48 jokoho48 unpinned this issue Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants