Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist: hbcd_motion_postproc #19

Closed
1 task done
mgxd opened this issue Nov 18, 2024 · 6 comments
Closed
1 task done

Checklist: hbcd_motion_postproc #19

mgxd opened this issue Nov 18, 2024 · 6 comments
Assignees
Labels
approved Approval for tool checklist checklist Denote checklist submission

Comments

@mgxd
Copy link
Collaborator

mgxd commented Nov 18, 2024

Checklist content

{
  "name": "hbcd_motion_postproc",
  "urls": [
    {
      "url_type": "Source code",
      "url": "https://github.com/ohspc89/hbcd_motion_postproc"
    },
    {
      "url_type": "Documentation",
      "url": "https://hbcd-motion-postproc.readthedocs.io/en/latest/"
    }
  ],
  "documentation": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true,
      "8": true,
      "9": true
    },
    "silver": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": false,
      "5": false,
      "6": false
    }
  },
  "infrastructure": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true
    },
    "silver": {
      "1": false,
      "2": false,
      "3": true
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": false,
      "5": false
    }
  },
  "testing": {
    "bronze": {
      "1": false,
      "2": false
    },
    "silver": {
      "1": false,
      "2": false
    },
    "gold": {
      "1": false,
      "2": false
    }
  }
}

Additional information

No response

Agreement

  • I agree
@mgxd mgxd added the checklist Denote checklist submission label Nov 18, 2024
@LuciMoore
Copy link
Collaborator

Next steps: I'll follow up with the developers to make improvements and resubmit an updated checklist, at which point I'll indicate to the NMIND team that it is ready for their final editorial review

@LuciMoore
Copy link
Collaborator

I updated the checklist above to reflect that this tool now has a Zenodo DOI

@LuciMoore
Copy link
Collaborator

@kaitj this tool is now ready for final NMIND review

@kaitj
Copy link
Collaborator

kaitj commented Dec 3, 2024

@LuciMoore - this one largely looks good to me. One minor suggested change is related to infrastructure / silver / no excessive files. There are a couple of .DS_STORE files, which I believe are macOS specific related to attributes? These can probably be removed, or the checklist can be updated (see below) unless there is a necessity for it.

{
  "name": "hbcd_motion_postproc",
  "urls": [
    {
      "url_type": "Source code",
      "url": "https://github.com/ohspc89/hbcd_motion_postproc"
    },
    {
      "url_type": "Documentation",
      "url": "https://hbcd-motion-postproc.readthedocs.io/en/latest/"
    }
  ],
  "documentation": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true,
      "8": true,
      "9": true
    },
    "silver": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": false,
      "5": false,
      "6": false
    }
  },
  "infrastructure": {
    "bronze": {
      "1": true,
      "2": true,
      "3": true,
      "4": true,
      "5": true,
      "6": true,
      "7": true
    },
    "silver": {
      "1": false,
      "2": false,
      "3": false
    },
    "gold": {
      "1": false,
      "2": false,
      "3": false,
      "4": false,
      "5": false
    }
  },
  "testing": {
    "bronze": {
      "1": false,
      "2": false
    },
    "silver": {
      "1": false,
      "2": false
    },
    "gold": {
      "1": false,
      "2": false
    }
  }
}

@LuciMoore
Copy link
Collaborator

@kaitj thank you, I've posted an issue here and will let you know when it's ready for final approval

@LuciMoore
Copy link
Collaborator

@kaitj they've removed the excess files, so I'll go ahead and approve!

@LuciMoore LuciMoore added the approved Approval for tool checklist label Dec 4, 2024
github-actions bot added a commit that referenced this issue Dec 4, 2024
@kaitj kaitj closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approval for tool checklist checklist Denote checklist submission
Projects
None yet
Development

No branches or pull requests

3 participants