Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regard of 1PR/1Commit rule #597

Open
DonghwanJeong opened this issue Dec 3, 2019 · 4 comments
Open

Regard of 1PR/1Commit rule #597

DonghwanJeong opened this issue Dec 3, 2019 · 4 comments
Assignees

Comments

@DonghwanJeong
Copy link

Related of #596

1PR/1Commit rule may make interfere with software configuration management.
It want to be reviewed using this system regardless commit count at same PR.
Already branch merge rule is used at many project. For example, follow under git tree, this commit is refer by linux kernel.

* 872e24d - (HEAD -> master) hexagon: remove asm/bitsperlong.h (3 weeks ago) <Masahiro Yamada>
* 31f4f5b - (tag: v5.4-rc7) Linux 5.4-rc7 (3 weeks ago) <Linus Torvalds>
*   4486695 - Merge tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc (3 weeks ago) <Linus Torvalds>
|\  
| * 002d3c6 - MAINTAINERS: update Cavium ThunderX2 maintainers (4 weeks ago) <Jayachandran C>
| *   e1af5a1 - Merge tag 'stm32-dt-for-v5.4-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32 into arm/fixes (4 weeks ago) <Olof Johansson>
| |\  
| | * f4d6e0f - ARM: dts: stm32: change joystick pinctrl definition on stm32mp157c-ev1 (4 weeks ago) <Amelie Delaunay>
| | * afe3af8 - ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1 (4 weeks ago) <Amelie Delaunay>
| | * 9df50c2 - ARM: dts: stm32: Fix CAN RAM mapping on stm32mp157c (4 weeks ago) <Christophe Roullier>
| | * 832c436 - ARM: dts: stm32: relax qspi pins slew-rate for stm32mp157 (4 weeks ago) <Patrice Chotard>
| * |   3a82cd4 - Merge tag 'imx-fixes-5.4-3' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes (4 weeks ago) <Olof Johansson>
| |\ \  
| | * | f852497 - arm64: dts: zii-ultra: fix ARM regulator GPIO handle (4 weeks ago) <Lucas Stach>
| * | |   ba7f8c9 - Merge tag 'sunxi-fixes-for-5.4-2' of https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux into arm/fixes (4 weeks ago) <Olof Johansson>
| |\ \ \  
| | * | | e690053 - ARM: sunxi: Fix CPU powerdown on A83T (5 weeks ago) <Ondrej Jirman>
| | * | | e614f34 - ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend (5 weeks ago) <Ondrej Jirman>
| * | | |   70a7274 - Merge tag 'imx-fixes-5.4-2' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes (4 weeks ago) <Olof Johansson>
| |\ \ \ \  
| | | |/ /  
| | |/| |   
| | * | | 958c601 - arm64: dts: imx8mn: fix compatible string for sdma (5 weeks ago) <Shengjiu Wang>
| | * | | e346ff9 - arm64: dts: imx8mm: fix compatible string for sdma (5 weeks ago) <Shengjiu Wang>
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 3, 2019

:octocat: cibot: Thank you for posting issue #597. The person in charge will reply soon.

@myungjoo
Copy link
Member

myungjoo commented Dec 3, 2019

I think you can disable that rule (plugin) if you want.

Such heavy branching as in Linux kernel is appropriate ONLY if we can afford to have a dedicated maintainer for each branch. In most projects, we can't.

@leemgs leemgs self-assigned this Dec 3, 2019
@leemgs
Copy link
Collaborator

leemgs commented Dec 3, 2019

I added this issue into the Kanban board of TAOS-CI to handle 1PR/Ncommits (TODO) as well as 1PR/1commit (currently).

@leemgs
Copy link
Collaborator

leemgs commented Dec 3, 2019

I have added it to the official Kanban board to support the request positively.

  • 1PR / 1commit policy
  • 1PR / Ncommits policy (Coming soon in the near future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants