Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell command is exposed. #609

Open
jijoongmoon opened this issue Mar 24, 2020 · 2 comments
Open

Shell command is exposed. #609

jijoongmoon opened this issue Mar 24, 2020 · 2 comments
Labels
Open for Participation

Comments

@jijoongmoon
Copy link
Contributor

When I use the PR Report Handler in "Standalone Continuous Integration Server" Web Interface, there is shell command exposed as below.

ID and Pasword is correct.
Running the PR comment handler ...
Updating the PR status.
shell_exec("./pr-handler-runner.sh "success" "TAOS/pr-postbuild-build-android" ":octocat:[TEST] The current status is chaged by a web-based PR handler." "bdb3d6f3a67cd2d9447f6d63a7cb52563d9430f6"")

It's okay, The PR handler completed your request.
@taos-ci
Copy link
Collaborator

taos-ci commented Mar 24, 2020

:octocat: cibot: Thank you for posting issue #609. The person in charge will reply soon.

leemgs added a commit that referenced this issue Mar 24, 2020
@leemgs
Web: Updated the PR handler
1bad272 
Fixed issue #609.

This commit is to remove unnecessary statements.
Until now, the some statement of debugging still are exist.
Let's remove the unnecessary and deprecated statement.

Signed-off-by: Geunsik Lim <[email protected]>
@leemgs leemgs mentioned this issue Mar 24, 2020
Merged
leemgs added a commit that referenced this issue Mar 24, 2020
@leemgs
Web: Updated the PR handler
6bf93b0 
Fixed issue #609.

This commit is to remove unnecessary statements.
Until now, the some statement of debugging still are exist.
Let's remove the unnecessary and deprecated statement.

Signed-off-by: Geunsik Lim <[email protected]>
@leemgs leemgs closed this as completed Mar 24, 2020
@leemgs leemgs reopened this Mar 25, 2020
@leemgs
Copy link
Collaborator

leemgs commented Mar 25, 2020

It seems that the issue is not still fixed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Open for Participation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leemgs @jijoongmoon @taos-ci